]> www.infradead.org Git - users/willy/linux.git/commitdiff
net/sched: Use TC_RTAB_SIZE instead of magic number
authorYue Haibing <yuehaibing@huawei.com>
Wed, 13 Aug 2025 12:55:26 +0000 (20:55 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 15 Aug 2025 00:37:48 +0000 (17:37 -0700)
Replace magic number with TC_RTAB_SIZE to make it more informative.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Link: https://patch.msgid.link/20250813125526.853895-1-yuehaibing@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_api.c

index d7c767b861a4651caac949430f4b71e79b868d50..1e058b46d3e1715584633720fb3508c7b8dbd312 100644 (file)
@@ -431,7 +431,7 @@ struct qdisc_rate_table *qdisc_get_rtab(struct tc_ratespec *r,
 
        for (rtab = qdisc_rtab_list; rtab; rtab = rtab->next) {
                if (!memcmp(&rtab->rate, r, sizeof(struct tc_ratespec)) &&
-                   !memcmp(&rtab->data, nla_data(tab), 1024)) {
+                   !memcmp(&rtab->data, nla_data(tab), TC_RTAB_SIZE)) {
                        rtab->refcnt++;
                        return rtab;
                }
@@ -441,7 +441,7 @@ struct qdisc_rate_table *qdisc_get_rtab(struct tc_ratespec *r,
        if (rtab) {
                rtab->rate = *r;
                rtab->refcnt = 1;
-               memcpy(rtab->data, nla_data(tab), 1024);
+               memcpy(rtab->data, nla_data(tab), TC_RTAB_SIZE);
                if (r->linklayer == TC_LINKLAYER_UNAWARE)
                        r->linklayer = __detect_linklayer(r, rtab->data);
                rtab->next = qdisc_rtab_list;