]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: frequency: adf4371: drop clkin from struct adf4371_state
authorNuno Sa <nuno.sa@analog.com>
Wed, 9 Oct 2024 14:16:45 +0000 (16:16 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 10 Oct 2024 18:12:42 +0000 (19:12 +0100)
We already cache clkin rate during probe and then never use the clk
object again. Hence, no point in saving in our global state struct.

Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Link: https://patch.msgid.link/20241009-dev-adf4371-minor-improv-v1-3-97f4f22ed941@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/frequency/adf4371.c

index eb31f442566c24eb08f244e70bd30fda53340db2..45c8398a45d0ea6cc4691f273ec5e4d4bba54b0b 100644 (file)
@@ -158,7 +158,6 @@ struct adf4371_chip_info {
 struct adf4371_state {
        struct spi_device *spi;
        struct regmap *regmap;
-       struct clk *clkin;
        /*
         * Lock for accessing device registers. Some operations require
         * multiple consecutive R/W operations, during which the device
@@ -547,6 +546,7 @@ static int adf4371_probe(struct spi_device *spi)
        struct iio_dev *indio_dev;
        struct adf4371_state *st;
        struct regmap *regmap;
+       struct clk *clkin;
        int ret;
 
        indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
@@ -575,11 +575,11 @@ static int adf4371_probe(struct spi_device *spi)
        indio_dev->channels = st->chip_info->channels;
        indio_dev->num_channels = st->chip_info->num_channels;
 
-       st->clkin = devm_clk_get_enabled(&spi->dev, "clkin");
-       if (IS_ERR(st->clkin))
-               return PTR_ERR(st->clkin);
+       clkin = devm_clk_get_enabled(&spi->dev, "clkin");
+       if (IS_ERR(clkin))
+               return PTR_ERR(clkin);
 
-       st->clkin_freq = clk_get_rate(st->clkin);
+       st->clkin_freq = clk_get_rate(clkin);
 
        ret = adf4371_setup(st);
        if (ret < 0) {