]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
MIPS: OCTEON: add missing put_device() call in dwc3_octeon_device_init()
authorYu Kuai <yukuai3@huawei.com>
Tue, 21 Jul 2020 13:47:18 +0000 (21:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 07:48:10 +0000 (09:48 +0200)
[ Upstream commit e8b9fc10f2615b9a525fce56981e40b489528355 ]

if of_find_device_by_node() succeed, dwc3_octeon_device_init() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.

Fixes: 93e502b3c2d4 ("MIPS: OCTEON: Platform support for OCTEON III USB controller")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/mips/cavium-octeon/octeon-usb.c

index bfdfaf32d2c49742066329e800a6b535f363c3e1..75189ff2f3c78315f6c550174188a03d7563ab00 100644 (file)
@@ -517,6 +517,7 @@ static int __init dwc3_octeon_device_init(void)
 
                        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
                        if (res == NULL) {
+                               put_device(&pdev->dev);
                                dev_err(&pdev->dev, "No memory resources\n");
                                return -ENXIO;
                        }
@@ -528,8 +529,10 @@ static int __init dwc3_octeon_device_init(void)
                         * know the difference.
                         */
                        base = devm_ioremap_resource(&pdev->dev, res);
-                       if (IS_ERR(base))
+                       if (IS_ERR(base)) {
+                               put_device(&pdev->dev);
                                return PTR_ERR(base);
+                       }
 
                        mutex_lock(&dwc3_octeon_clocks_mutex);
                        dwc3_octeon_clocks_start(&pdev->dev, (u64)base);