]> www.infradead.org Git - nvme.git/commitdiff
riscv: cacheinfo: remove the useless input parameter (node) of ci_leaf_init()
authorYunhui Cui <cuiyunhui@bytedance.com>
Mon, 17 Jun 2024 13:14:23 +0000 (21:14 +0800)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 24 Jul 2024 14:39:35 +0000 (07:39 -0700)
ci_leaf_init() is a declared static function. The implementation of the
function body and the caller do not use the parameter (struct device_node
*node) input parameter, so remove it.

Fixes: 6a24915145c9 ("Revert "riscv: Set more data to cacheinfo"")
Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20240617131425.7526-1-cuiyunhui@bytedance.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/cacheinfo.c

index 09e9b88110d1519b98f57be22badeaa2e8802a93..30a6878287ad40dd1615b13c35eed883cabd4995 100644 (file)
@@ -64,7 +64,6 @@ uintptr_t get_cache_geometry(u32 level, enum cache_type type)
 }
 
 static void ci_leaf_init(struct cacheinfo *this_leaf,
-                        struct device_node *node,
                         enum cache_type type, unsigned int level)
 {
        this_leaf->level = level;
@@ -80,11 +79,11 @@ int populate_cache_leaves(unsigned int cpu)
        int levels = 1, level = 1;
 
        if (of_property_read_bool(np, "cache-size"))
-               ci_leaf_init(this_leaf++, np, CACHE_TYPE_UNIFIED, level);
+               ci_leaf_init(this_leaf++, CACHE_TYPE_UNIFIED, level);
        if (of_property_read_bool(np, "i-cache-size"))
-               ci_leaf_init(this_leaf++, np, CACHE_TYPE_INST, level);
+               ci_leaf_init(this_leaf++, CACHE_TYPE_INST, level);
        if (of_property_read_bool(np, "d-cache-size"))
-               ci_leaf_init(this_leaf++, np, CACHE_TYPE_DATA, level);
+               ci_leaf_init(this_leaf++, CACHE_TYPE_DATA, level);
 
        prev = np;
        while ((np = of_find_next_cache_node(np))) {
@@ -97,11 +96,11 @@ int populate_cache_leaves(unsigned int cpu)
                if (level <= levels)
                        break;
                if (of_property_read_bool(np, "cache-size"))
-                       ci_leaf_init(this_leaf++, np, CACHE_TYPE_UNIFIED, level);
+                       ci_leaf_init(this_leaf++, CACHE_TYPE_UNIFIED, level);
                if (of_property_read_bool(np, "i-cache-size"))
-                       ci_leaf_init(this_leaf++, np, CACHE_TYPE_INST, level);
+                       ci_leaf_init(this_leaf++, CACHE_TYPE_INST, level);
                if (of_property_read_bool(np, "d-cache-size"))
-                       ci_leaf_init(this_leaf++, np, CACHE_TYPE_DATA, level);
+                       ci_leaf_init(this_leaf++, CACHE_TYPE_DATA, level);
                levels = level;
        }
        of_node_put(np);