drm/i915/gvt: Fix static checker warning on intel_gvt_i2c_handle_aux_ch_write()

Static checker gave warning on:

drivers/gpu/drm/i915/gvt/edid.c:506 intel_gvt_i2c_handle_aux_ch_write()
warn: odd binop '0x0 & 0xff'

We try to return ACK for I2C reply which is defined with 0. Remove
bit shift which caused misleading bit op.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>

diff --git a/drivers/gpu/drm/i915/gvt/edid.c b/drivers/gpu/drm/i915/gvt/edid.c
index 7e1da1c563ca8453cf2eab237994a6b8f5eb6c88..bda85dff7b2a998d68d1485479c9687eab206600 100644 (file)
--- a/drivers/gpu/drm/i915/gvt/edid.c
+++ b/drivers/gpu/drm/i915/gvt/edid.c
@@ -502,8 +502,7 @@ void intel_gvt_i2c_handle_aux_ch_write(struct intel_vgpu *vgpu,
         * ACK of I2C_WRITE
         * returned byte if it is READ
         */
-
-       aux_data_for_write |= (GVT_AUX_I2C_REPLY_ACK & 0xff) << 24;
+       aux_data_for_write |= GVT_AUX_I2C_REPLY_ACK << 24;
        vgpu_vreg(vgpu, offset + 4) = aux_data_for_write;
 }
 

diff --git a/drivers/gpu/drm/i915/gvt/edid.h b/drivers/gpu/drm/i915/gvt/edid.h
index de366b1d5196e7dc8cc664951661f895498a5478..f6dfc8b795ec2f3d57d3314052b72dd98eabd599 100644 (file)
--- a/drivers/gpu/drm/i915/gvt/edid.h
+++ b/drivers/gpu/drm/i915/gvt/edid.h
@@ -44,7 +44,7 @@
 #define GVT_AUX_I2C_READ                       0x1
 #define GVT_AUX_I2C_STATUS                     0x2
 #define GVT_AUX_I2C_MOT                                0x4
-#define GVT_AUX_I2C_REPLY_ACK                  (0x0 << 6)
+#define GVT_AUX_I2C_REPLY_ACK                  0x0
 
 struct intel_vgpu_edid_data {
        bool data_valid;