drm/arm/komeda: don't use confusing 'timeout' variable name

There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Check the return value directly to drop
'timeout'  which also fixes its wrong type.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240507090200.7936-2-wsa+renesas@sang-engineering.com
[changed commit title to match driver name]
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
index 2c661f28410eda2d297a1fe33b0f33e003af775c..9bec59cf9c0670019dd9a90e4c7c0173a23dee6c 100644 (file)
--- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
@@ -294,7 +294,6 @@ komeda_crtc_flush_and_wait_for_flip_done(struct komeda_crtc *kcrtc,
        struct komeda_dev *mdev = kcrtc->master->mdev;
        struct completion *flip_done;
        struct completion temp;
-       int timeout;
 
        /* if caller doesn't send a flip_done, use a private flip_done */
        if (input_flip_done) {
@@ -308,8 +307,7 @@ komeda_crtc_flush_and_wait_for_flip_done(struct komeda_crtc *kcrtc,
        mdev->funcs->flush(mdev, kcrtc->master->id, 0);
 
        /* wait the flip take affect.*/
-       timeout = wait_for_completion_timeout(flip_done, HZ);
-       if (timeout == 0) {
+       if (wait_for_completion_timeout(flip_done, HZ) == 0) {
                DRM_ERROR("wait pipe%d flip done timeout\n", kcrtc->master->id);
                if (!input_flip_done) {
                        unsigned long flags;