]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
net: hibmcge: Remove the use of dev_err_probe()
authorXichao Zhao <zhao.xichao@vivo.com>
Wed, 20 Aug 2025 08:57:48 +0000 (16:57 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 Aug 2025 22:51:42 +0000 (15:51 -0700)
The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
Therefore, remove the useless call to dev_err_probe(), and just
return the value instead.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Link: https://patch.msgid.link/20250820085749.397586-2-zhao.xichao@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c
drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.c

index 2e64dc1ab355e321106a55e3f81d5dde69508e32..0b92a2e5e98694635d1f27da0ffbaa1df038c9a4 100644 (file)
@@ -417,7 +417,7 @@ static int hbg_pci_init(struct pci_dev *pdev)
 
        priv->io_base = pcim_iomap_table(pdev)[0];
        if (!priv->io_base)
-               return dev_err_probe(dev, -ENOMEM, "failed to get io base\n");
+               return -ENOMEM;
 
        pci_set_master(pdev);
        return 0;
index 8b7b476ed7fbfee38fe6807771513a0ba5c8cff2..37791de47f6ffc1a874745b2073ca0b2414d824f 100644 (file)
@@ -278,8 +278,7 @@ int hbg_mdio_init(struct hbg_priv *priv)
 
        mdio_bus = devm_mdiobus_alloc(dev);
        if (!mdio_bus)
-               return dev_err_probe(dev, -ENOMEM,
-                                    "failed to alloc MDIO bus\n");
+               return -ENOMEM;
 
        mdio_bus->parent = dev;
        mdio_bus->priv = priv;