]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd: Move microcode init from sw_init to early_init for SDMA v5.0
authorMario Limonciello <mario.limonciello@amd.com>
Mon, 25 Sep 2023 18:56:16 +0000 (13:56 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Sep 2023 19:37:34 +0000 (15:37 -0400)
As part of IP discovery early_init is run for all HW IP blocks.
During this phase all firmware is supposed to be identified that may
be missing so that the driver can avoid releasing resources used by
the EFI framebuffer or simpledrm until the last possible moment.

Move microcode loading from sw_init to early_init.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c

index 7e837acffa6eb0ddf373e9b7e03f26868fc9abfa..c1ff5eda89619fe22a35fd4198a18104430ea409 100644 (file)
@@ -1336,6 +1336,11 @@ static void sdma_v5_0_ring_emit_reg_write_reg_wait(struct amdgpu_ring *ring,
 static int sdma_v5_0_early_init(void *handle)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
+       int r;
+
+       r = sdma_v5_0_init_microcode(adev);
+       if (r)
+               return r;
 
        sdma_v5_0_set_ring_funcs(adev);
        sdma_v5_0_set_buffer_funcs(adev);
@@ -1367,10 +1372,6 @@ static int sdma_v5_0_sw_init(void *handle)
        if (r)
                return r;
 
-       r = sdma_v5_0_init_microcode(adev);
-       if (r)
-               return r;
-
        for (i = 0; i < adev->sdma.num_instances; i++) {
                ring = &adev->sdma.instance[i].ring;
                ring->ring_obj = NULL;