reset: lpc18xx: simplify with dev_err_probe()

Use dev_err_probe() to avoid dmesg flood on actual defer.  This makes
the code also simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Link: https://lore.kernel.org/r/20240825-reset-cleanup-scoped-v1-4-03f6d834f8c0@linaro.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

diff --git a/drivers/reset/reset-lpc18xx.c b/drivers/reset/reset-lpc18xx.c
index 28fb85772b3e2559c9f512282a7529f37a81b130..e7896e3f1851b4cea3dbdf6d7a1dd333a41b722d 100644 (file)
--- a/drivers/reset/reset-lpc18xx.c
+++ b/drivers/reset/reset-lpc18xx.c
@@ -151,16 +151,14 @@ static int lpc18xx_rgu_probe(struct platform_device *pdev)
                return PTR_ERR(rc->base);
 
        rc->clk_reg = devm_clk_get(&pdev->dev, "reg");
-       if (IS_ERR(rc->clk_reg)) {
-               dev_err(&pdev->dev, "reg clock not found\n");
-               return PTR_ERR(rc->clk_reg);
-       }
+       if (IS_ERR(rc->clk_reg))
+               return dev_err_probe(&pdev->dev, PTR_ERR(rc->clk_reg),
+                                    "reg clock not found\n");
 
        rc->clk_delay = devm_clk_get(&pdev->dev, "delay");
-       if (IS_ERR(rc->clk_delay)) {
-               dev_err(&pdev->dev, "delay clock not found\n");
-               return PTR_ERR(rc->clk_delay);
-       }
+       if (IS_ERR(rc->clk_delay))
+               return dev_err_probe(&pdev->dev, PTR_ERR(rc->clk_delay),
+                                    "delay clock not found\n");
 
        ret = clk_prepare_enable(rc->clk_reg);
        if (ret) {