ALSA: hda: Fix regressions on clear and reconfig sysfs

commit 2506318e382c4c7daa77bdc48f80a0ee82804588 upstream.

It seems that the HD-audio clear and reconfig sysfs don't work any
longer after the recent driver core change.  There are multiple issues
around that: the linked list corruption and the dead device handling.
The former issue is fixed by another patch for the driver core itself,
while the latter patch needs to be addressed in HD-audio side.

This patch corresponds to the latter, it recovers those broken
functions by replacing the device detach and attach actions with the
standard core API functions, which are almost equivalent with unbind
and bind actions.

Fixes: 654888327e9f ("driver core: Avoid binding drivers to dead devices")
Cc: <stable@vger.kernel.org>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209207
Link: https://lore.kernel.org/r/20201209150119.7705-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index dbeb62362f1c3954af07d31835fdaf3ecc84ceca..7f1e763ccca8820a1d275a7e8b5304c682aeb9f0 100644 (file)
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -1782,7 +1782,7 @@ int snd_hda_codec_reset(struct hda_codec *codec)
                return -EBUSY;
 
        /* OK, let it free */
-       snd_hdac_device_unregister(&codec->core);
+       device_release_driver(hda_codec_dev(codec));
 
        /* allow device access again */
        snd_hda_unlock_devices(bus);

diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c
index 6535155e992dfe4cfb0d223bb16037c665953c1e..25a4c2d580daef0e9d4ada8c71e04a2d92f94645 100644 (file)
--- a/sound/pci/hda/hda_sysfs.c
+++ b/sound/pci/hda/hda_sysfs.c
@@ -138,7 +138,7 @@ static int reconfig_codec(struct hda_codec *codec)
                           "The codec is being used, can't reconfigure.\n");
                goto error;
        }
-       err = snd_hda_codec_configure(codec);
+       err = device_reprobe(hda_codec_dev(codec));
        if (err < 0)
                goto error;
        err = snd_card_register(codec->card);