]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants
authorLech Perczak <lech.perczak@camlingroup.com>
Mon, 26 Aug 2024 15:42:01 +0000 (17:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Sep 2024 08:47:10 +0000 (10:47 +0200)
Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3,
which don't match the datasheet - fix them.
At the same time remove comments for individual constants, as they add
nothing to the definitions themselves.

Signed-off-by: Lech Perczak <lech.perczak@camlingroup.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/2986a485-935d-4ab2-9a16-4a85288aa15a@camlingroup.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sc16is7xx.c

index fed3a753d211075b2b8dbb71a6f9196fbd43b00d..0b6ec0a316a99f432b156e992383171daa22c0f4 100644 (file)
                                                  * and writing to IER[7:4],
                                                  * FCR[5:4], MCR[7:5]
                                                  */
-#define SC16IS7XX_EFR_SWFLOW3_BIT      (1 << 3) /* SWFLOW bit 3 */
-#define SC16IS7XX_EFR_SWFLOW2_BIT      (1 << 2) /* SWFLOW bit 2
-                                                 *
+#define SC16IS7XX_EFR_SWFLOW3_BIT      (1 << 3)
+#define SC16IS7XX_EFR_SWFLOW2_BIT      (1 << 2)
+                                                /*
                                                  * SWFLOW bits 3 & 2 table:
                                                  * 00 -> no transmitter flow
                                                  *       control
                                                  *       XON1, XON2, XOFF1 and
                                                  *       XOFF2
                                                  */
-#define SC16IS7XX_EFR_SWFLOW1_BIT      (1 << 1) /* SWFLOW bit 2 */
-#define SC16IS7XX_EFR_SWFLOW0_BIT      (1 << 0) /* SWFLOW bit 3
-                                                 *
-                                                 * SWFLOW bits 3 & 2 table:
+#define SC16IS7XX_EFR_SWFLOW1_BIT      (1 << 1)
+#define SC16IS7XX_EFR_SWFLOW0_BIT      (1 << 0)
+                                                /*
+                                                 * SWFLOW bits 1 & 0 table:
                                                  * 00 -> no received flow
                                                  *       control
                                                  * 01 -> receiver compares