]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Wed, 28 Feb 2024 08:17:40 +0000 (09:17 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Sat, 9 Mar 2024 17:51:45 +0000 (18:51 +0100)
The "isapc" machine only provides an ISA bus, not a PCI one,
and doesn't instanciate any i440FX south bridge.
Its machine class defines PCMachineClass::pci_enabled = false,
and pc_init1() only uses the pci_type argument when pci_enabled
is true. Since for this machine the argument is not used,
passing NULL makes more sense.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
Message-Id: <20240301185936.95175-5-philmd@linaro.org>

hw/i386/pc_piix.c

index e14dce951d9faff99f4cc040e4743d8fe64c41b2..319bc4b1801fb7c70e025752f05cb9e82f06e889 100644 (file)
@@ -450,7 +450,7 @@ static void pc_compat_2_0_fn(MachineState *machine)
 #ifdef CONFIG_ISAPC
 static void pc_init_isa(MachineState *machine)
 {
-    pc_init1(machine, TYPE_I440FX_PCI_DEVICE);
+    pc_init1(machine, NULL);
 }
 #endif