]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net/nfc/rawsock.c: fix a permission check bug
authorJeimon <jjjinmeng.zhou@gmail.com>
Sat, 8 May 2021 03:52:30 +0000 (11:52 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Jun 2021 09:54:56 +0000 (11:54 +0200)
[ Upstream commit 8ab78863e9eff11910e1ac8bcf478060c29b379e ]

The function rawsock_create() calls a privileged function sk_alloc(), which requires a ns-aware check to check net->user_ns, i.e., ns_capable(). However, the original code checks the init_user_ns using capable(). So we replace the capable() with ns_capable().

Signed-off-by: Jeimon <jjjinmeng.zhou@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/nfc/rawsock.c

index 57a07ab80d924d1e3256df20046a7471cc412ff7..bdc72737fe240c7d17f09deb03278406a0010894 100644 (file)
@@ -345,7 +345,7 @@ static int rawsock_create(struct net *net, struct socket *sock,
                return -ESOCKTNOSUPPORT;
 
        if (sock->type == SOCK_RAW) {
-               if (!capable(CAP_NET_RAW))
+               if (!ns_capable(net->user_ns, CAP_NET_RAW))
                        return -EPERM;
                sock->ops = &rawsock_raw_ops;
        } else {