of: add consistency check to of_node_release()

Add an additional consistency check to of_node_release(), which is
called when the reference count of a devicetree node is decremented
to zero.  The node's children should have been deleted before the
node is deleted so check that no children exist.

Signed-off-by: Frank Rowand <frowand.list@gmail.com>
Link: https://lore.kernel.org/r/20230213185702.395776-7-frowand.list@gmail.com
Signed-off-by: Rob Herring <robh@kernel.org>

diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index dbcbc41f34651c3f6471f3c31fdaf86c2c0f1585..657a65006056be4e0f15aedee36c4c7f939eba78 100644 (file)
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -377,6 +377,10 @@ void of_node_release(struct kobject *kobj)
                               __func__, node);
        }
 
+       if (node->child)
+               pr_err("ERROR: %s() unexpected children for %pOF/%s\n",
+                       __func__, node->parent, node->full_name);
+
        property_list_free(node->properties);
        property_list_free(node->deadprops);
        fwnode_links_purge(of_fwnode_handle(node));