]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: stmmac: mdio: update runtime PM
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 29 Aug 2025 09:02:29 +0000 (10:02 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 1 Sep 2025 20:10:06 +0000 (13:10 -0700)
Commit 3c7826d0b106 ("net: stmmac: Separate C22 and C45 transactions
for xgmac") missed a change that happened in commit e2d0acd40c87
("net: stmmac: using pm_runtime_resume_and_get instead of
pm_runtime_get_sync").

Update the two clause 45 functions that didn't get switched to
pm_runtime_resume_and_get().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/E1urv09-00000000gJ1-3SxO@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

index da4542be756a1a035b9c9da9e7daa14c89e6b1ff..0a302b711bc2793fc5f9e71b2bd6b94e52a50460 100644 (file)
@@ -303,11 +303,9 @@ static int stmmac_mdio_read_c45(struct mii_bus *bus, int phyaddr, int devad,
        u32 value = MII_BUSY;
        int data = 0;
 
-       data = pm_runtime_get_sync(priv->device);
-       if (data < 0) {
-               pm_runtime_put_noidle(priv->device);
+       data = pm_runtime_resume_and_get(priv->device);
+       if (data < 0)
                return data;
-       }
 
        value |= (phyaddr << priv->hw->mii.addr_shift)
                & priv->hw->mii.addr_mask;
@@ -399,11 +397,9 @@ static int stmmac_mdio_write_c45(struct mii_bus *bus, int phyaddr,
        int ret, data = phydata;
        u32 value = MII_BUSY;
 
-       ret = pm_runtime_get_sync(priv->device);
-       if (ret < 0) {
-               pm_runtime_put_noidle(priv->device);
+       ret = pm_runtime_resume_and_get(priv->device);
+       if (ret < 0)
                return ret;
-       }
 
        value |= (phyaddr << priv->hw->mii.addr_shift)
                & priv->hw->mii.addr_mask;