]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/sched: Remove mention of indirect buffers
authorTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Thu, 14 Aug 2025 13:36:27 +0000 (14:36 +0100)
committerPhilipp Stanner <phasta@kernel.org>
Thu, 28 Aug 2025 08:09:12 +0000 (10:09 +0200)
Indirect buffers are an AMD term describing essentialy a job submitted to
the scheduler, just a lower level one. Since scheduler was promoted to be
generic long ago, lets replace those references with jobs.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250814133627.2550-1-tvrtko.ursulin@igalia.com
drivers/gpu/drm/scheduler/sched_entity.c

index 8867b95ab089ce6f8df5f3c42df7f42c7820e868..254932b9050e2e5e9e9420dd8bfc24999ed1d10c 100644 (file)
@@ -285,9 +285,9 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
                return 0;
 
        sched = entity->rq->sched;
-       /**
-        * The client will not queue more IBs during this fini, consume existing
-        * queued IBs or discard them on SIGKILL
+       /*
+        * The client will not queue more jobs during this fini - consume
+        * existing queued ones, or discard them on SIGKILL.
         */
        if (current->flags & PF_EXITING) {
                if (timeout)
@@ -300,7 +300,7 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
                                    drm_sched_entity_is_idle(entity));
        }
 
-       /* For killed process disable any more IBs enqueue right now */
+       /* For a killed process disallow further enqueueing of jobs. */
        last_user = cmpxchg(&entity->last_user, current->group_leader, NULL);
        if ((!last_user || last_user == current->group_leader) &&
            (current->flags & PF_EXITING) && (current->exit_code == SIGKILL))
@@ -324,9 +324,9 @@ EXPORT_SYMBOL(drm_sched_entity_flush);
 void drm_sched_entity_fini(struct drm_sched_entity *entity)
 {
        /*
-        * If consumption of existing IBs wasn't completed. Forcefully remove
-        * them here. Also makes sure that the scheduler won't touch this entity
-        * any more.
+        * If consumption of existing jobs wasn't completed forcefully remove
+        * them. Also makes sure that the scheduler won't touch this entity any
+        * more.
         */
        drm_sched_entity_kill(entity);