nandtest: fix --reads argument

The --reads option specifies the argument as optional, but doesn't check
for a null optarg, which means that nandtest segfaults when run as
"nandtest --reads".

Fix this by making the argument required, and changing the help text to
not specify it as optional. Argument -r already specifies the argument
as required, so we fix this inconsistency too.

Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Acked-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

diff --git a/nandtest.c b/nandtest.c
index 8ea39d3bcf5267acc947b8ee2fdc08e9cb67112d..08053876506aebcc9e3b073c936e3525acca8594 100644 (file)
--- a/nandtest.c
+++ b/nandtest.c
@@ -24,7 +24,7 @@ void usage(int status)
                "  -m, --markbad        Mark blocks bad if they appear so\n"
                "  -s, --seed           Supply random seed\n"
                "  -p, --passes         Number of passes\n"
-               "  -r, --reads          Read & check iterations per pass (default=4)\n"
+               "  -r <n>, --reads=<n>  Read & check <n> times per pass\n"
                "  -o, --offset         Start offset on flash\n"
                "  -l, --length         Length of flash to test\n"
                "  -k, --keep           Restore existing contents after test\n",
@@ -166,7 +166,7 @@ int main(int argc, char **argv)
                        { "passes", required_argument, 0, 'p' },
                        { "offset", required_argument, 0, 'o' },
                        { "length", required_argument, 0, 'l' },
-                       { "reads", optional_argument, 0, 'r' },
+                       { "reads", required_argument, 0, 'r' },
                        { "keep", no_argument, 0, 'k' },
                        {0, 0, 0, 0},
                };