scsi: bfa: Drop driver-defined SCSI status codes

Drop the driver-defined SCSI status codes and use the generic ones instead.

Link: https://lore.kernel.org/r/20210113090500.129644-10-hare@suse.de
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/bfa/bfa_fc.h b/drivers/scsi/bfa/bfa_fc.h
index b00fb2409c50cc370b06200efdf0dc3166ae107a..d536270bbe9f70e44b9793a9e75979e66a4a289c 100644 (file)
--- a/drivers/scsi/bfa/bfa_fc.h
+++ b/drivers/scsi/bfa/bfa_fc.h
@@ -33,21 +33,6 @@ struct scsi_cdb_s {
        u8         scsi_cdb[SCSI_MAX_CDBLEN];
 };
 
-/* ------------------------------------------------------------
- * SCSI status byte values
- * ------------------------------------------------------------
- */
-#define SCSI_STATUS_GOOD                   0x00
-#define SCSI_STATUS_CHECK_CONDITION        0x02
-#define SCSI_STATUS_CONDITION_MET          0x04
-#define SCSI_STATUS_BUSY                   0x08
-#define SCSI_STATUS_INTERMEDIATE           0x10
-#define SCSI_STATUS_ICM                    0x14 /* intermediate condition met */
-#define SCSI_STATUS_RESERVATION_CONFLICT   0x18
-#define SCSI_STATUS_COMMAND_TERMINATED     0x22
-#define SCSI_STATUS_QUEUE_FULL             0x28
-#define SCSI_STATUS_ACA_ACTIVE             0x30
-
 #define SCSI_MAX_ALLOC_LEN      0xFF    /* maximum allocarion length */
 
 /*

diff --git a/drivers/scsi/bfa/bfa_fcpim.c b/drivers/scsi/bfa/bfa_fcpim.c
index 38d1c453074dc1d91198d1aed575b18f40c1afbe..7ad22288071b130486de2b667f1a6f6dd15b12c0 100644 (file)
--- a/drivers/scsi/bfa/bfa_fcpim.c
+++ b/drivers/scsi/bfa/bfa_fcpim.c
@@ -2146,7 +2146,7 @@ __bfa_cb_ioim_comp(void *cbarg, bfa_boolean_t complete)
                /*
                 * setup sense information, if present
                 */
-               if ((m->scsi_status == SCSI_STATUS_CHECK_CONDITION) &&
+               if ((m->scsi_status == SAM_STAT_CHECK_CONDITION) &&
                                        m->sns_len) {
                        sns_len = m->sns_len;
                        snsinfo = BFA_SNSINFO_FROM_TAG(ioim->fcpim->fcp,

diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c
index 22f06be2606f56f174b5720701d098d8cf1b7429..6b5841b1c06e8eccc0966bf4464c4e1e972594d5 100644 (file)
--- a/drivers/scsi/bfa/bfad_im.c
+++ b/drivers/scsi/bfa/bfad_im.c
@@ -106,7 +106,7 @@ bfa_cb_ioim_good_comp(void *drv, struct bfad_ioim_s *dio)
        struct bfad_itnim_data_s *itnim_data;
        struct bfad_itnim_s *itnim;
 
-       cmnd->result = DID_OK << 16 | SCSI_STATUS_GOOD;
+       cmnd->result = DID_OK << 16 | SAM_STAT_GOOD;
 
        /* Unmap DMA, if host is NULL, it means a scsi passthru cmd */
        if (cmnd->device->host != NULL)