]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
rtc: s3c: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 19 Sep 2022 08:38:12 +0000 (16:38 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 15 Nov 2022 20:01:51 +0000 (21:01 +0100)
In the probe path, dev_err() can be replace with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220919083812.755082-1-yangyingliang@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-s3c.c

index db529733c9c46c7e8967a701f27235c09e0bb716..8fc5efde3e0b30c19b8f2e87e8ad05ae35483d05 100644 (file)
@@ -429,14 +429,9 @@ static int s3c_rtc_probe(struct platform_device *pdev)
                return PTR_ERR(info->base);
 
        info->rtc_clk = devm_clk_get(&pdev->dev, "rtc");
-       if (IS_ERR(info->rtc_clk)) {
-               ret = PTR_ERR(info->rtc_clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to find rtc clock\n");
-               else
-                       dev_dbg(&pdev->dev, "probe deferred due to missing rtc clk\n");
-               return ret;
-       }
+       if (IS_ERR(info->rtc_clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(info->rtc_clk),
+                                    "failed to find rtc clock\n");
        ret = clk_prepare_enable(info->rtc_clk);
        if (ret)
                return ret;