]> www.infradead.org Git - nvme.git/commitdiff
net: Add notifications when multipath hash field change
authorIdo Schimmel <idosch@nvidia.com>
Wed, 19 May 2021 12:08:18 +0000 (15:08 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 May 2021 19:47:47 +0000 (12:47 -0700)
In-kernel notifications are already sent when the multipath hash policy
itself changes, but not when the multipath hash fields change.

Add these notifications, so that interested listeners (e.g., switch ASIC
drivers) could perform the necessary configuration.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/sysctl_net_ipv4.c
net/ipv6/sysctl_net_ipv6.c

index ffb38ea06841a637344ada746093c62b8a715f41..4fa77f182dcb111a199d43856f8bd7893ec9adc0 100644 (file)
@@ -465,6 +465,22 @@ static int proc_fib_multipath_hash_policy(struct ctl_table *table, int write,
 
        return ret;
 }
+
+static int proc_fib_multipath_hash_fields(struct ctl_table *table, int write,
+                                         void *buffer, size_t *lenp,
+                                         loff_t *ppos)
+{
+       struct net *net;
+       int ret;
+
+       net = container_of(table->data, struct net,
+                          ipv4.sysctl_fib_multipath_hash_fields);
+       ret = proc_douintvec_minmax(table, write, buffer, lenp, ppos);
+       if (write && ret == 0)
+               call_netevent_notifiers(NETEVENT_IPV4_MPATH_HASH_UPDATE, net);
+
+       return ret;
+}
 #endif
 
 static struct ctl_table ipv4_table[] = {
@@ -1061,7 +1077,7 @@ static struct ctl_table ipv4_net_table[] = {
                .data           = &init_net.ipv4.sysctl_fib_multipath_hash_fields,
                .maxlen         = sizeof(u32),
                .mode           = 0644,
-               .proc_handler   = proc_douintvec_minmax,
+               .proc_handler   = proc_fib_multipath_hash_fields,
                .extra1         = SYSCTL_ONE,
                .extra2         = &fib_multipath_hash_fields_all_mask,
        },
index 160bea5db973b70c98f448a4c34c85138764440e..d7cf26f730d72c64487b1c5858b78019b44202da 100644 (file)
@@ -44,6 +44,22 @@ static int proc_rt6_multipath_hash_policy(struct ctl_table *table, int write,
        return ret;
 }
 
+static int
+proc_rt6_multipath_hash_fields(struct ctl_table *table, int write, void *buffer,
+                              size_t *lenp, loff_t *ppos)
+{
+       struct net *net;
+       int ret;
+
+       net = container_of(table->data, struct net,
+                          ipv6.sysctl.multipath_hash_fields);
+       ret = proc_douintvec_minmax(table, write, buffer, lenp, ppos);
+       if (write && ret == 0)
+               call_netevent_notifiers(NETEVENT_IPV6_MPATH_HASH_UPDATE, net);
+
+       return ret;
+}
+
 static struct ctl_table ipv6_table_template[] = {
        {
                .procname       = "bindv6only",
@@ -160,7 +176,7 @@ static struct ctl_table ipv6_table_template[] = {
                .data           = &init_net.ipv6.sysctl.multipath_hash_fields,
                .maxlen         = sizeof(u32),
                .mode           = 0644,
-               .proc_handler   = proc_douintvec_minmax,
+               .proc_handler   = proc_rt6_multipath_hash_fields,
                .extra1         = SYSCTL_ONE,
                .extra2         = &rt6_multipath_hash_fields_all_mask,
        },