platform/x86: int3472: Stop setting a supply-name for GPIO regulators

The supply_name field is not mandatory and is supposed to be set to
the name of another regulator when it is known that the regulator being
registered is supplied by that other regulator.

Having a regulator supplying the regulator which is being registered does
not apply to the INT3472 GPIO regulator, stop setting a supply_name.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: David Heidelberg <david@ixit.cz>  # Dell Latitude 9440
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20250417111337.38142-3-hdegoede@redhat.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/platform/x86/intel/int3472/clk_and_regulator.c b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
index 837990af24fe62b5f9e742b9aa6d95696a093b49..40434591dd0be51d130a1ebe06e01c45bf8f33e9 100644 (file)
--- a/drivers/platform/x86/intel/int3472/clk_and_regulator.c
+++ b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
@@ -256,12 +256,9 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,
        snprintf(int3472->regulator.regulator_name,
                 sizeof(int3472->regulator.regulator_name), "%s-regulator",
                 acpi_dev_name(int3472->adev));
-       snprintf(int3472->regulator.supply_name,
-                GPIO_REGULATOR_SUPPLY_NAME_LENGTH, "supply-0");
 
        int3472->regulator.rdesc = INT3472_REGULATOR(
                                                int3472->regulator.regulator_name,
-                                               int3472->regulator.supply_name,
                                                &int3472_gpio_regulator_ops);
 
        int3472->regulator.gpio = gpio;

diff --git a/drivers/platform/x86/intel/int3472/common.h b/drivers/platform/x86/intel/int3472/common.h
index 145dec66df64ac382e4313a7a40fd2a1d8e1a20e..72ef222629b627e1f62700ceacc26e70e04abc73 100644 (file)
--- a/drivers/platform/x86/intel/int3472/common.h
+++ b/drivers/platform/x86/intel/int3472/common.h
@@ -27,17 +27,15 @@
 #define INT3472_MAX_SENSOR_GPIOS                               3
 
 #define GPIO_REGULATOR_NAME_LENGTH                             21
-#define GPIO_REGULATOR_SUPPLY_NAME_LENGTH                      9
 #define GPIO_REGULATOR_SUPPLY_MAP_COUNT                                2
 
 #define INT3472_LED_MAX_NAME_LEN                               32
 
 #define CIO2_SENSOR_SSDB_MCLKSPEED_OFFSET                      86
 
-#define INT3472_REGULATOR(_name, _supply, _ops)                        \
+#define INT3472_REGULATOR(_name, _ops)                         \
        (const struct regulator_desc) {                         \
                .name = _name,                                  \
-               .supply_name = _supply,                         \
                .type = REGULATOR_VOLTAGE,                      \
                .ops = _ops,                                    \
                .owner = THIS_MODULE,                           \
@@ -82,7 +80,6 @@ struct int3472_discrete_device {
                /* SUPPLY_MAP_COUNT * 2 to make room for second sensor mappings */
                struct regulator_consumer_supply supply_map[GPIO_REGULATOR_SUPPLY_MAP_COUNT * 2];
                char regulator_name[GPIO_REGULATOR_NAME_LENGTH];
-               char supply_name[GPIO_REGULATOR_SUPPLY_NAME_LENGTH];
                struct gpio_desc *gpio;
                struct regulator_dev *rdev;
                struct regulator_desc rdesc;