]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/xe: Generate oob before compiling anything
authorLucas De Marchi <lucas.demarchi@intel.com>
Mon, 8 Jul 2024 21:29:06 +0000 (14:29 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Wed, 10 Jul 2024 06:27:48 +0000 (23:27 -0700)
Instead of keep adding more dependencies as WAs are needed in different
places of the driver, just add a rule with all the objects so the code
generation happens before anything else.

While at it, group lines related to wa_oob in the Makefile.

v2: Prefix $(obj) when declaring dependency

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240708213041.1734028-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/Makefile

index 0eb0acc4f198bd1269e0171aab2f549b3e828382..1ff9602a52f67a430d4a782bd3533a9fccf1694d 100644 (file)
@@ -12,35 +12,15 @@ subdir-ccflags-$(CONFIG_DRM_XE_WERROR) += -Werror
 subdir-ccflags-y += -I$(obj) -I$(src)
 
 # generated sources
-hostprogs := xe_gen_wa_oob
 
+hostprogs := xe_gen_wa_oob
 generated_oob := $(obj)/generated/xe_wa_oob.c $(obj)/generated/xe_wa_oob.h
-
 quiet_cmd_wa_oob = GEN     $(notdir $(generated_oob))
       cmd_wa_oob = mkdir -p $(@D); $^ $(generated_oob)
-
 $(obj)/generated/%_wa_oob.c $(obj)/generated/%_wa_oob.h: $(obj)/xe_gen_wa_oob \
                 $(src)/xe_wa_oob.rules
        $(call cmd,wa_oob)
 
-uses_generated_oob := \
-       $(obj)/xe_ggtt.o \
-       $(obj)/xe_device.o \
-       $(obj)/xe_gsc.o \
-       $(obj)/xe_gt.o \
-       $(obj)/xe_guc.o \
-       $(obj)/xe_guc_ads.o \
-       $(obj)/xe_guc_pc.o \
-       $(obj)/xe_migrate.o \
-       $(obj)/xe_pat.o \
-       $(obj)/xe_ring_ops.o \
-       $(obj)/xe_vm.o \
-       $(obj)/xe_wa.o \
-       $(obj)/xe_ttm_stolen_mgr.o \
-       $(obj)/display/xe_display_wa.o
-
-$(uses_generated_oob): $(generated_oob)
-
 # Please keep these build lists sorted!
 
 # core driver code
@@ -324,3 +304,6 @@ quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
 
 $(obj)/%.hdrtest: $(src)/%.h FORCE
        $(call if_changed_dep,hdrtest)
+
+uses_generated_oob := $(addprefix $(obj)/, $(xe-y))
+$(uses_generated_oob): $(obj)/generated/xe_wa_oob.h