The core will do this for us now.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Ray Jui <ray.jui@broadcom.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
                 amd756_ioport);
 
        error = i2c_add_adapter(&amd756_smbus);
-       if (error) {
-               dev_err(&pdev->dev,
-                       "Adapter registration failed, module not inserted\n");
+       if (error)
                goto out_err;
-       }
 
        return 0;
 
 
 
        rc = i2c_add_numbered_adapter(&dev->adapter);
        if (rc) {
-               dev_err(dev->dev, "Adapter %s registration failed\n",
-                       dev->adapter.name);
                clk_disable_unprepare(dev->clk);
 
                pm_runtime_disable(dev->dev);
 
 
        platform_set_drvdata(pdev, idev);
 
-       ret = i2c_add_adapter(&idev->adapter);
-       if (ret) {
-               dev_err(&pdev->dev, "failed to add adapter\n");
-               return ret;
-       }
-
-       return 0;
+       return i2c_add_adapter(&idev->adapter);
 }
 
 static int axxia_i2c_remove(struct platform_device *pdev)
 
        adap->dev.parent = &pdev->dev;
        adap->dev.of_node = pdev->dev.of_node;
 
-       ret = i2c_add_adapter(adap);
-       if (ret) {
-               dev_err(iproc_i2c->device, "failed to add adapter\n");
-               return ret;
-       }
-
-       return 0;
+       return i2c_add_adapter(adap);
 }
 
 static int bcm_iproc_i2c_remove(struct platform_device *pdev)
 
        adap->dev.of_node = pdev->dev.of_node;
 
        rc = i2c_add_adapter(adap);
-       if (rc) {
-               dev_err(dev->device, "failed to add adapter\n");
+       if (rc)
                return rc;
-       }
 
        dev_info(dev->device, "device registered successfully\n");
 
 
        write_CONTROL(iface, read_CONTROL(iface) | TWI_ENA);
 
        rc = i2c_add_numbered_adapter(p_adap);
-       if (rc < 0) {
-               dev_err(&pdev->dev, "Can't add i2c adapter!\n");
+       if (rc < 0)
                goto out_error;
-       }
 
        platform_set_drvdata(pdev, iface);
 
 
        adap->dev.parent = &pdev->dev;
        adap->dev.of_node = pdev->dev.of_node;
        rc = i2c_add_adapter(adap);
-       if (rc) {
-               dev_err(dev->device, "failed to add adapter\n");
+       if (rc)
                goto probe_errorout;
-       }
 
        dev_info(dev->device, "%s@%dhz registered in %s mode\n",
                 int_name ? int_name : " ", dev->clk_freq_hz,
 
        }
 
        ret = i2c_add_adapter(&id->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "reg adap failed: %d\n", ret);
+       if (ret < 0)
                goto err_clk_dis;
-       }
 
        /*
         * Cadence I2C controller has a bug wherein it generates
 
        cpm->adap.nr = (data && len == 4) ? be32_to_cpup(data) : -1;
        result = i2c_add_numbered_adapter(&cpm->adap);
 
-       if (result < 0) {
-               dev_err(&ofdev->dev, "Unable to register with I2C\n");
+       if (result < 0)
                goto out_shut;
-       }
 
        dev_dbg(&ofdev->dev, "hw routines for %s registered.\n",
                cpm->adap.name);
 
        bus->adap.retries = I2C_MAX_RETRIES;
 
        err = i2c_add_adapter(&bus->adap);
-       if (err) {
-               dev_err(dev, "cannot register i2c adapter\n");
+       if (err)
                return err;
-       }
        platform_set_drvdata(pdev, bus);
 
        return err;
 
 
        adap->nr = pdev->id;
        r = i2c_add_numbered_adapter(adap);
-       if (r) {
-               dev_err(&pdev->dev, "failure adding adapter\n");
+       if (r)
                goto err_unuse_clocks;
-       }
 
        return 0;
 
 
 
        /* and finally attach to i2c layer */
        ret = i2c_add_adapter(&dev->adapter);
-       if (ret < 0) {
-               dev_err(&interface->dev, "failed to add I2C adapter\n");
+       if (ret < 0)
                goto error_free;
-       }
 
        dev_dbg(&interface->dev, "connected " DRIVER_NAME "\n");
 
 
 
        /* and finally attach to i2c layer */
        ret = i2c_add_adapter(&dln2->adapter);
-       if (ret < 0) {
-               dev_err(dev, "failed to add I2C adapter: %d\n", ret);
+       if (ret < 0)
                goto out_disable;
-       }
 
        return 0;
 
 
 
        ret = i2c_add_adapter(&ddata->adapter);
        if (ret) {
-               dev_err(&pdev->dev, "failed to add i2c adapter (%d)\n", ret);
                free_irq(ddata->irq, ddata);
 
 err_disable_clk:
 
        exynos5_i2c_reset(i2c);
 
        ret = i2c_add_adapter(&i2c->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "failed to add bus to i2c core\n");
+       if (ret < 0)
                goto err_clk;
-       }
 
        platform_set_drvdata(pdev, i2c);
 
 
        pm_runtime_enable(priv->dev);
 
        ret = i2c_add_adapter(&priv->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "failed to add bus to i2c core\n");
+       if (ret < 0)
                goto err_runtime;
-       }
 
        return ret;
 
 
                "SMBus I801 adapter at %04lx", priv->smba);
        err = i2c_add_adapter(&priv->adapter);
        if (err) {
-               dev_err(&dev->dev, "Failed to add SMBus adapter\n");
                i801_acpi_remove(priv);
                return err;
        }
 
        adap->timeout = HZ;
 
        ret = i2c_add_adapter(adap);
-       if (ret  < 0) {
-               dev_err(&ofdev->dev, "failed to register i2c adapter\n");
+       if (ret  < 0)
                goto error_cleanup;
-       }
 
        dev_info(&ofdev->dev, "using %s mode\n",
                 dev->fast_mode ? "fast (400 kHz)" : "standard (100 kHz)");
 
                goto disable_clk;
 
        ret = i2c_add_numbered_adapter(&i2c->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "failed to add adapter\n");
+       if (ret < 0)
                goto disable_clk;
-       }
 
        return 0;
 
 
 
        /* Add I2C adapter */
        ret = i2c_add_numbered_adapter(&i2c_imx->adapter);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "registration failed\n");
+       if (ret < 0)
                goto rpm_disable;
-       }
 
        pm_runtime_mark_last_busy(&pdev->dev);
        pm_runtime_put_autosuspend(&pdev->dev);
 
                "SMBus SCH adapter at %04x", sch_smba);
 
        retval = i2c_add_adapter(&sch_adapter);
-       if (retval) {
-               dev_err(&dev->dev, "Couldn't register adapter!\n");
+       if (retval)
                sch_smba = 0;
-       }
 
        return retval;
 }
 
                return err;
 
        err = i2c_add_adapter(&priv->adapter);
-       if (err) {
-               dev_err(&pdev->dev, "Failed to add SMBus iSMT adapter\n");
+       if (err)
                return -ENODEV;
-       }
        return 0;
 }
 
 
                goto err;
 
        ret = i2c_add_adapter(&i2c->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "Failed to add bus\n");
+       if (ret < 0)
                goto err;
-       }
 
        return 0;
 
 
        i2c->adap.dev.of_node = pdev->dev.of_node;
 
        ret = i2c_add_adapter(&i2c->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "failed to add adapter!\n");
+       if (ret < 0)
                goto fail_clk;
-       }
 
        dev_info(&pdev->dev, "LPC2K I2C adapter\n");
 
 
 
        ret = i2c_add_adapter(&i2c->adap);
        if (ret < 0) {
-               dev_err(&pdev->dev, "can't register adapter\n");
                clk_unprepare(i2c->clk);
                return ret;
        }
 
        i2c->adap.dev.of_node = of_node_get(op->dev.of_node);
 
        result = i2c_add_adapter(&i2c->adap);
-       if (result < 0) {
-               dev_err(i2c->dev, "failed to add adapter\n");
+       if (result < 0)
                goto fail_add;
-       }
 
        return result;
 
 
 
        i2c_set_adapdata(&i2c->adap, i2c);
        ret = i2c_add_adapter(&i2c->adap);
-       if (ret) {
-               dev_err(&pdev->dev, "Failed to add i2c bus to i2c core\n");
+       if (ret)
                return ret;
-       }
 
        platform_set_drvdata(pdev, i2c);
 
 
        i2c_set_adapdata(adap, i2c);
        err = i2c_add_numbered_adapter(adap);
        if (err) {
-               dev_err(dev, "Failed to add adapter (%d)\n", err);
                writel(MXS_I2C_CTRL0_SFTRST,
                                i2c->regs + MXS_I2C_CTRL0_SET);
                return err;
 
 
        error = i2c_add_adapter(&smbus->adapter);
        if (error) {
-               dev_err(&smbus->adapter.dev, "Failed to register adapter.\n");
                release_region(smbus->base, smbus->size);
                return error;
        }
 
                 adap->name, dev->virtbase);
 
        ret = i2c_add_adapter(adap);
-       if (ret) {
-               dev_err(&adev->dev, "failed to add adapter\n");
+       if (ret)
                goto err_no_adap;
-       }
 
        pm_runtime_put(&adev->dev);
 
 
 
        /* add i2c adapter to i2c tree */
        ret = i2c_add_adapter(&i2c->adap);
-       if (ret) {
-               dev_err(&pdev->dev, "Failed to add adapter\n");
+       if (ret)
                goto err_clk;
-       }
 
        /* add in known devices to the bus */
        if (pdata) {
 
        platform_set_drvdata(pdev, i2c);
 
        result = i2c_add_adapter(&i2c->adap);
-       if (result < 0) {
-               dev_err(i2c->dev, "failed to add adapter\n");
+       if (result < 0)
                goto out;
-       }
        dev_info(i2c->dev, "probed\n");
        return 0;
 
 
        /* i2c device drivers may be active on return from add_adapter() */
        adap->nr = pdev->id;
        r = i2c_add_numbered_adapter(adap);
-       if (r) {
-               dev_err(omap->dev, "failure adding adapter\n");
+       if (r)
                goto err_unuse_clocks;
-       }
 
        dev_info(omap->dev, "bus %d rev%d.%d at %d kHz\n", adap->nr,
                 major, minor, omap->speed);
 
 
        retval = i2c_add_adapter(adap);
        if (retval) {
-               dev_err(&dev->dev, "Couldn't register adapter!\n");
                kfree(adapdata);
                kfree(adap);
                release_region(smba, SMBIOSIZE);
 
        i2c_set_adapdata(&pmcmsptwi_adapter, &pmcmsptwi_data);
 
        rc = i2c_add_adapter(&pmcmsptwi_adapter);
-       if (rc) {
-               dev_err(&pldev->dev, "Unable to register I2C adapter\n");
+       if (rc)
                goto ret_unmap;
-       }
 
        return 0;
 
 
 
        /* Register this adapter with the I2C subsystem */
        ret = i2c_add_numbered_adapter(&alg_data->adapter);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "I2C: Failed to add bus\n");
+       if (ret < 0)
                goto out_clock;
-       }
 
        dev_dbg(&pdev->dev, "%s: Master at %#8x, irq %d.\n",
                alg_data->adapter.name, res->start, alg_data->irq);
 
 
        adapter->nr = pdev->id;
        rc = i2c_add_numbered_adapter(adapter);
-       if (rc) {
-               dev_err(&pdev->dev, "Adapter '%s' registration failed\n",
-                               adapter->name);
+       if (rc)
                goto fail_add_adapter;
-       }
 
        dev_info(&pdev->dev, "PKUnity v3 i2c bus adapter.\n");
        return 0;
 
 #endif
 
        ret = i2c_add_numbered_adapter(&i2c->adap);
-       if (ret < 0) {
-               dev_err(&dev->dev, "failed to add bus: %d\n", ret);
+       if (ret < 0)
                goto ereqirq;
-       }
 
        platform_set_drvdata(dev, i2c);
 
 
        platform_set_drvdata(pdev, priv);
 
        ret = i2c_add_numbered_adapter(adap);
-       if (ret < 0) {
-               dev_err(dev, "reg adap failed: %d\n", ret);
+       if (ret < 0)
                goto out_pm_disable;
-       }
 
        dev_info(dev, "probed\n");
 
 
 
 
        ret = i2c_add_adapter(adap);
-       if (ret) {
-               dev_err(&pdev->dev, "failed to add adapter\n");
+       if (ret)
                return ret;
-       }
 
        platform_set_drvdata(pdev, riic);
 
 
        rk3x_i2c_adapt_div(i2c, clk_rate);
 
        ret = i2c_add_adapter(&i2c->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "Could not register adapter\n");
+       if (ret < 0)
                goto err_clk_notifier;
-       }
 
        dev_info(&pdev->dev, "Initialized RK3xxx I2C bus at %p\n", i2c->regs);
 
 
 
        ret = i2c_add_numbered_adapter(&i2c->adap);
        if (ret < 0) {
-               dev_err(&pdev->dev, "failed to add bus to i2c core\n");
                pm_runtime_disable(&pdev->dev);
                s3c24xx_i2c_deregister_cpufreq(i2c);
                clk_unprepare(i2c->clk);
 
        }
 
        ret = i2c_add_numbered_adapter(&id->adap);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "reg adap failed: %d\n", ret);
+       if (ret < 0)
                goto out4;
-       }
 
        platform_set_drvdata(pdev, id);
 
 
        ret = i2c_add_numbered_adapter(adap);
        if (ret < 0) {
                sh_mobile_i2c_release_dma(pd);
-               dev_err(&dev->dev, "cannot add numbered adapter\n");
                return ret;
        }
 
 
                writel(regval, siic->base + SIRFSOC_I2C_SDA_DELAY);
 
        err = i2c_add_numbered_adapter(adap);
-       if (err < 0) {
-               dev_err(&pdev->dev, "Can't add new i2c adapter\n");
+       if (err < 0)
                goto out;
-       }
 
        clk_disable(clk);
 
 
        init_completion(&i2c_dev->complete);
 
        ret = i2c_add_adapter(adap);
-       if (ret) {
-               dev_err(&pdev->dev, "Failed to add adapter\n");
+       if (ret)
                return ret;
-       }
 
        platform_set_drvdata(pdev, i2c_dev);
 
 
 
        /* i2c device drivers may be active on return from add_adapter() */
        ret = i2c_add_numbered_adapter(adap);
-       if (ret) {
-               dev_err(&pdev->dev, "failure adding ST Micro DDC "
-                      "I2C adapter\n");
+       if (ret)
                return ret;
-       }
 
        platform_set_drvdata(pdev, dev);
        dev_info(&pdev->dev, "ST DDC I2C @ %p, irq %d\n",
 
        i2c_dev->adapter.dev.of_node = pdev->dev.of_node;
 
        ret = i2c_add_numbered_adapter(&i2c_dev->adapter);
-       if (ret) {
-               dev_err(&pdev->dev, "Failed to add I2C adapter\n");
+       if (ret)
                goto disable_div_clk;
-       }
 
        return 0;
 
 
        }
 
        err = i2c_add_adapter(adap);
-       if (err) {
-               dev_err(&pdev->dev, "failed to add adapter\n");
+       if (err)
                return err;
-       }
 
        platform_set_drvdata(pdev, i2c_dev);
 
 
        i2c_set_adapdata(adapter, ctx);
        rc = i2c_add_adapter(adapter);
        if (rc) {
-               dev_err(&pdev->dev, "Adapter registeration failed\n");
                mbox_free_channel(ctx->mbox_chan);
                return rc;
        }
 
        /* add i2c adapter to i2c tree */
        ret = i2c_add_adapter(&i2c->adap);
        if (ret) {
-               dev_err(&pdev->dev, "Failed to add adapter\n");
                xiic_deinit(i2c);
                goto err_clk_dis;
        }
 
        i2c_set_adapdata(&priv->adapter, priv);
 
        err = i2c_add_adapter(&priv->adapter);
-       if (err) {
-               dev_err(&pdev->dev, "failed to add I2C adapter!\n");
+       if (err)
                return err;
-       }
 
        platform_set_drvdata(pdev, priv);
        dev_dbg(&pdev->dev, "I2C bus:%d added\n", priv->adapter.nr);
 
 
        i2c_set_adapdata(&priv->adap, priv);
        ret = i2c_add_numbered_adapter(&priv->adap);
-       if (ret < 0) {
-               dev_err(&priv->adap.dev, "Failed to add i2c bus.\n");
+       if (ret < 0)
                return ret;
-       }
 
        platform_set_drvdata(pdev, priv);
        dev_info(&priv->adap.dev, "Added I2C Bus.\n");