]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ntb: intel: Fix memleak in intel_ntb_pci_probe
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Sun, 23 Aug 2020 06:55:12 +0000 (14:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:12:07 +0000 (10:12 +0100)
[ Upstream commit dbb8df5c2d27610a87b0168a8acc89d73fbfde94 ]

The default error branch of a series of pdev_is_gen calls
should free ndev just like what we've done in these calls.

Fixes: 26bfe3d0b227 ("ntb: intel: Add Icelake (gen4) support for Intel NTB")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ntb/hw/intel/ntb_hw_gen1.c

index 3185efeab487ba6f93dc3d699b6abf68536e203b..093dd20057b9274f3f27e7ba6b68e3a517597d15 100644 (file)
@@ -1893,7 +1893,7 @@ static int intel_ntb_pci_probe(struct pci_dev *pdev,
                        goto err_init_dev;
        } else {
                rc = -EINVAL;
-               goto err_ndev;
+               goto err_init_pci;
        }
 
        ndev_reset_unsafe_flags(ndev);