]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
parse_prelogin_xml: removed unnecessary initialization
authorNikos Mavrogiannopoulos <nmav@redhat.com>
Thu, 12 Nov 2020 14:57:51 +0000 (15:57 +0100)
committerNikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
Tue, 17 Nov 2020 12:53:13 +0000 (13:53 +0100)
Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
auth-globalprotect.c

index 5185d4746543f8a7d9e18f7b8433b8a1687b2e04..6f9cbcc00953a9ab4a1262c7ed0f54677518974f 100644 (file)
@@ -74,7 +74,7 @@ const char *gpst_os_name(struct openconnect_info *vpninfo)
 static int parse_prelogin_xml(struct openconnect_info *vpninfo, xmlNode *xml_node, void *cb_data)
 {
        struct login_context *ctx = cb_data;
-       struct oc_auth_form *form = ctx->form;
+       struct oc_auth_form *form = NULL;
        struct oc_form_opt *opt, *opt2;
        char *prompt = NULL, *username_label = NULL, *password_label = NULL;
        char *saml_method = NULL, *saml_path = NULL;
@@ -132,7 +132,6 @@ static int parse_prelogin_xml(struct openconnect_info *vpninfo, xmlNode *xml_nod
        }
 
        /* Replace old form */
-       free_auth_form(ctx->form);
        form = ctx->form = calloc(1, sizeof(*form));
        if (!form) {
        nomem: