usb: cdns3: cdnsp-pci: remove redundant pci_disable_device() call

The cdnsp-pci driver uses pcim_enable_device() to enable a PCI device,
which means the device will be automatically disabled on driver detach
through the managed device framework. The manual pci_disable_device()
call in the error path is therefore redundant.

Found via static anlaysis and this is similar to commit 99ca0b57e49f
("thermal: intel: int340x: processor: Fix warning during module unload").

Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20250903141613.2535472-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/cdns3/cdnsp-pci.c b/drivers/usb/cdns3/cdnsp-pci.c
index 8c361b8394e9591712fbe648e48332ce3c607b3a..5e7b88ca8b96c0360933e9a0488e7d9b12793ee3 100644 (file)
--- a/drivers/usb/cdns3/cdnsp-pci.c
+++ b/drivers/usb/cdns3/cdnsp-pci.c
@@ -85,7 +85,7 @@ static int cdnsp_pci_probe(struct pci_dev *pdev,
                cdnsp = kzalloc(sizeof(*cdnsp), GFP_KERNEL);
                if (!cdnsp) {
                        ret = -ENOMEM;
-                       goto disable_pci;
+                       goto put_pci;
                }
        }
 
@@ -168,9 +168,6 @@ free_cdnsp:
        if (!pci_is_enabled(func))
                kfree(cdnsp);
 
-disable_pci:
-       pci_disable_device(pdev);
-
 put_pci:
        pci_dev_put(func);