]> www.infradead.org Git - nvme.git/commitdiff
perf symbol: Simplify kernel module checking
authorNamhyung Kim <namhyung@kernel.org>
Fri, 21 Jun 2024 17:05:26 +0000 (10:05 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 25 Jun 2024 18:06:20 +0000 (11:06 -0700)
In dso__load(), it checks if the dso is a kernel module by looking the
symtab type.  Actually dso has 'is_kmod' field to check that easily and
dso__set_module_info() set the symtab type and the is_kmod bit.  So it
should have the same result to check the is_kmod bit.

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240621170528.608772-3-namhyung@kernel.org
tools/perf/util/symbol.c

index aee0a4cfb383621f4dc7481740814ac90f3ef27e..478e922ce6764591babd73e714b53bb67acfe901 100644 (file)
@@ -1817,10 +1817,7 @@ int dso__load(struct dso *dso, struct map *map)
                goto out;
        }
 
-       kmod = dso__symtab_type(dso) == DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE ||
-               dso__symtab_type(dso) == DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE_COMP ||
-               dso__symtab_type(dso) == DSO_BINARY_TYPE__GUEST_KMODULE ||
-               dso__symtab_type(dso) == DSO_BINARY_TYPE__GUEST_KMODULE_COMP;
+       kmod = dso__is_kmod(dso);
 
        if (dso__kernel(dso) && !kmod) {
                if (dso__kernel(dso) == DSO_SPACE__KERNEL)