]> www.infradead.org Git - users/hch/misc.git/commitdiff
btrfs: tree-checker: fix bounds check in check_inode_extref()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 8 Oct 2025 15:08:58 +0000 (18:08 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 13 Oct 2025 20:35:51 +0000 (22:35 +0200)
The parentheses for the unlikely() annotation were put in the wrong
place so it means that the condition is basically never true and the
bounds checking is skipped.

Fixes: aab9458b9f00 ("btrfs: tree-checker: add inode extref checks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tree-checker.c

index ca30b15ea452343799f5421be0e68be7637da235..c10b4c242acfc98a40e496ae61812b9bf5a4f751 100644 (file)
@@ -1797,7 +1797,7 @@ static int check_inode_extref(struct extent_buffer *leaf,
                struct btrfs_inode_extref *extref = (struct btrfs_inode_extref *)ptr;
                u16 namelen;
 
-               if (unlikely(ptr + sizeof(*extref)) > end) {
+               if (unlikely(ptr + sizeof(*extref) > end)) {
                        inode_ref_err(leaf, slot,
                        "inode extref overflow, ptr %lu end %lu inode_extref size %zu",
                                      ptr, end, sizeof(*extref));