spi: mxs: fix reference leak in mxs_spi_probe

[ Upstream commit 03fc41afaa6549baa2dab7a84e1afaf5cadb5b18 ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in mxs_spi_probe, so we should fix it.

Fixes: b7969caf41a1d ("spi: mxs: implement runtime pm")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201106012421.95420-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 6ac95a2a21cef53bc7817c8403047e3b565ed478..4a7375ecb65ef85ab99026bae477e29cae76c0e7 100644 (file)
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -605,6 +605,7 @@ static int mxs_spi_probe(struct platform_device *pdev)
 
        ret = pm_runtime_get_sync(ssp->dev);
        if (ret < 0) {
+               pm_runtime_put_noidle(ssp->dev);
                dev_err(ssp->dev, "runtime_get_sync failed\n");
                goto out_pm_runtime_disable;
        }