USB: kobil: fix memory leak

commit c0f631d1948658b27349545b2cbcb4b32f010c7a upstream.

An urb transfer buffer is allocated at every open but was never freed.

This driver is a bit of a mess...

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index c113a2a0e10c529e198dcd9e6b7de868e27cddba..bd5bd8589e04cc300f43674079afa3f54715ee35 100644 (file)
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -345,7 +345,8 @@ static void kobil_close(struct usb_serial_port *port)
 
        /* FIXME: Add rts/dtr methods */
        if (port->write_urb) {
-               usb_kill_urb(port->write_urb);
+               usb_poison_urb(port->write_urb);
+               kfree(port->write_urb->transfer_buffer);
                usb_free_urb(port->write_urb);
                port->write_urb = NULL;
        }