]> www.infradead.org Git - users/sagi/blktests.git/commitdiff
nvme/rc: do not issue warnings on cleanup when using fc transport
authorDaniel Wagner <dwagner@suse.de>
Mon, 12 Feb 2024 10:40:44 +0000 (11:40 +0100)
committerShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tue, 13 Feb 2024 08:30:52 +0000 (17:30 +0900)
When running the tests with FC as transport and the udev auto connect
enabled, discovery controllers are created and destroyed while the tests
are running.

The cleanup code expects that all devices are under blktests control,
but this isn't the case. So just disable the warning as it is reporting
a lot of false positives.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
tests/nvme/rc

index 9cc83afe0668a5fda6a480298c9a014faeefdb9b..ca6a284a1e259a008de81b2a2eeed229e53c683e 100644 (file)
@@ -352,7 +352,10 @@ _cleanup_nvmet() {
                dev="$(basename "$dev")"
                transport="$(cat "/sys/class/nvme/${dev}/transport" 2>/dev/null)"
                if [[ "$transport" == "${nvme_trtype}" ]]; then
-                       echo "WARNING: Test did not clean up ${nvme_trtype} device: ${dev}"
+                       # if udev auto connect is enabled for FC we get false positives
+                       if [[ "$transport" != "fc" ]]; then
+                               echo "WARNING: Test did not clean up ${nvme_trtype} device: ${dev}"
+                       fi
                        _nvme_disconnect_ctrl "${dev}"
                fi
        done