]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
gpu: host1x: Correct allocated size for contexts
authorJohnny Liu <johnliu@nvidia.com>
Fri, 1 Sep 2023 11:59:09 +0000 (14:59 +0300)
committerThierry Reding <treding@nvidia.com>
Wed, 11 Oct 2023 20:52:44 +0000 (22:52 +0200)
Original implementation over allocates the memory size for the
contexts list. The size of memory for the contexts list is based
on the number of iommu groups specified in the device tree.

Fixes: 8aa5bcb61612 ("gpu: host1x: Add context device management code")
Signed-off-by: Johnny Liu <johnliu@nvidia.com>
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230901115910.701518-1-cyndis@kapsi.fi
drivers/gpu/host1x/context.c

index a3f336edd991b937d006b1d0df3fbdfa29f00750..955c971c528d429c7452cc8b15b0f932da51185c 100644 (file)
@@ -34,10 +34,10 @@ int host1x_memory_context_list_init(struct host1x *host1x)
        if (err < 0)
                return 0;
 
-       cdl->devs = kcalloc(err, sizeof(*cdl->devs), GFP_KERNEL);
+       cdl->len = err / 4;
+       cdl->devs = kcalloc(cdl->len, sizeof(*cdl->devs), GFP_KERNEL);
        if (!cdl->devs)
                return -ENOMEM;
-       cdl->len = err / 4;
 
        for (i = 0; i < cdl->len; i++) {
                ctx = &cdl->devs[i];