]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
ppc: fix double-free in cpu_post_load()
authorGreg Kurz <groug@kaod.org>
Wed, 2 Aug 2017 17:34:16 +0000 (19:34 +0200)
committerDavid Gibson <david@gibson.dropbear.id.au>
Wed, 9 Aug 2017 01:46:44 +0000 (11:46 +1000)
When running nested with KVM PR, ppc_set_compat() fails and QEMU crashes
because of "double free or corruption (!prev)". The crash happens because
error_report_err() has already called error_free().

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
target/ppc/machine.c

index f578156dd4116c4323212b3e12ed652aab2efc6f..abe0a1cdf021cf3ee5cc0449c1bf2631bed018b2 100644 (file)
@@ -239,7 +239,6 @@ static int cpu_post_load(void *opaque, int version_id)
         ppc_set_compat(cpu, cpu->compat_pvr, &local_err);
         if (local_err) {
             error_report_err(local_err);
-            error_free(local_err);
             return -1;
         }
     } else