]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
mtd: rawnand: fsmc: Fix error code in fsmc_nand_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 15 Feb 2021 15:58:49 +0000 (18:58 +0300)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 11 Mar 2021 08:37:29 +0000 (09:37 +0100)
If dma_request_channel() fails then the probe fails and it should
return a negative error code, but currently it returns success.

fixes: 4774fb0a48aa ("mtd: nand/fsmc: Add DMA support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/YCqaOZ83OvPOzLwh@mwanda
drivers/mtd/nand/raw/fsmc_nand.c

index 0101c0fab50adc0fca17ee7b5563f94743f793d1..a24e2f57fa68a7a58814de0061243e73bc5f5981 100644 (file)
@@ -1077,11 +1077,13 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
                host->read_dma_chan = dma_request_channel(mask, filter, NULL);
                if (!host->read_dma_chan) {
                        dev_err(&pdev->dev, "Unable to get read dma channel\n");
+                       ret = -ENODEV;
                        goto disable_clk;
                }
                host->write_dma_chan = dma_request_channel(mask, filter, NULL);
                if (!host->write_dma_chan) {
                        dev_err(&pdev->dev, "Unable to get write dma channel\n");
+                       ret = -ENODEV;
                        goto release_dma_read_chan;
                }
        }