qed: fix missing break in OOO_LB_TC case

Orabug: 25933053, 26439680

There seems to be a missing break on the OOO_LB_TC case, pq_id
is being assigned and then re-assigned on the fall through default
case and that seems suspect.

Detected by CoverityScan, CID#1424402 ("Missing break in switch")

Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Brian Maly <brian.maly@oracle.com>

diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 4a144ab361b06422782c3848860dbd362a6d8b32..a462b8ea65faa9895d2f60845dcbb1bf3b4c2b88 100644 (file)
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -1132,6 +1132,7 @@ static int qed_sp_ll2_tx_queue_start(struct qed_hwfn *p_hwfn,
                break;
        case OOO_LB_TC:
                pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OOO);
+               break;
        default:
                pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OFLD);
                break;