]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme: Fix nvme format block-size option handling
authorMateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Tue, 23 May 2023 13:14:26 +0000 (15:14 +0200)
committerDaniel Wagner <wagi@monom.org>
Wed, 24 May 2023 13:41:26 +0000 (15:41 +0200)
nlbaf returned by id-ns is a 0 based value, so the previous handling of
the loop skipped checking the last lbaf.

Signed-off-by: Mateusz Kozlowski <mateusz.kozlowski@solidigm.com>
nvme.c

diff --git a/nvme.c b/nvme.c
index 9bb328ceea0791aa8a7a4db1664d3e3010d87304..1520a7e849a4aec7757dd0c5006317bd853ab595 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -5818,7 +5818,7 @@ static int format_cmd(int argc, char **argv, struct command *cmd, struct plugin
                nvme_id_ns_flbas_to_lbaf_inuse(ns.flbas, &prev_lbaf);
 
                if (cfg.bs) {
-                       for (i = 0; i < ns.nlbaf; ++i) {
+                       for (i = 0; i <= ns.nlbaf; ++i) {
                                if ((1ULL << ns.lbaf[i].ds) == cfg.bs && ns.lbaf[i].ms == 0) {
                                        cfg.lbaf = i;
                                        break;