]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
watchdog: apple: Increase reset delay to 150ms
authorNick Chan <towinchenmi@gmail.com>
Tue, 1 Oct 2024 16:59:52 +0000 (00:59 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 4 Nov 2024 12:13:02 +0000 (13:13 +0100)
The Apple A8X SoC seems to be slowest at resetting, taking up to around
125ms to reset. Wait 150ms to be safe here.

Signed-off-by: Nick Chan <towinchenmi@gmail.com>
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20241001170018.20139-3-towinchenmi@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/apple_wdt.c

index 62dabf223d90960b06fec3e28030b7d3779052ac..95d9e37df41cd371a45b1390646cadc55fade72c 100644 (file)
@@ -127,11 +127,11 @@ static int apple_wdt_restart(struct watchdog_device *wdd, unsigned long mode,
        /*
         * Flush writes and then wait for the SoC to reset. Even though the
         * reset is queued almost immediately experiments have shown that it
-        * can take up to ~20-25ms until the SoC is actually reset. Just wait
-        * 50ms here to be safe.
+        * can take up to ~120-125ms until the SoC is actually reset. Just
+        * wait 150ms here to be safe.
         */
        (void)readl(wdt->regs + APPLE_WDT_WD1_CUR_TIME);
-       mdelay(50);
+       mdelay(150);
 
        return 0;
 }