rbd: release client list lock sooner

In rbd_get_client(), if a client is reused, a number of things
get done while still holding the list lock unnecessarily.

This just moves a few things that need no lock protection outside
the lock.

Signed-off-by: Alex Elder <elder@dreamhost.com>
Signed-off-by: Sage Weil <sage@newdream.net>

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 9ac1484a95ad74b038ed12ae7ed54fd8c523274d..bccd350a0323cb6c50e34e251a384209a78ee6f1 100644 (file)
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -383,13 +383,15 @@ static int rbd_get_client(struct rbd_device *rbd_dev, const char *mon_addr,
        spin_lock(&node_lock);
        rbdc = __rbd_client_find(opt);
        if (rbdc) {
-               ceph_destroy_options(opt);
-               kfree(rbd_opts);
-
                /* using an existing client */
                kref_get(&rbdc->kref);
-               rbd_dev->rbd_client = rbdc;
                spin_unlock(&node_lock);
+
+               rbd_dev->rbd_client = rbdc;
+
+               ceph_destroy_options(opt);
+               kfree(rbd_opts);
+
                return 0;
        }
        spin_unlock(&node_lock);