]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: hisilicon: hns_mdio: fix OF node leak in probe()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 27 Aug 2024 14:44:21 +0000 (16:44 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Aug 2024 00:55:24 +0000 (17:55 -0700)
Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240827144421.52852-4-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns_mdio.c

index ed73707176c1af123d3947529c7eadbfa4f160f2..8a047145f0c50b0f54c839613f8ac65c298b8288 100644 (file)
@@ -575,6 +575,7 @@ static int hns_mdio_probe(struct platform_device *pdev)
                                                MDIO_SC_RESET_ST;
                                }
                        }
+                       of_node_put(reg_args.np);
                } else {
                        dev_warn(&pdev->dev, "find syscon ret = %#x\n", ret);
                        mdio_dev->subctrl_vbase = NULL;