ksmbd: reduce descriptor size if remaining bytes is less than request size

Create 3 kinds of files to reproduce this problem.

dd if=/dev/urandom of=127k.bin bs=1024 count=127
dd if=/dev/urandom of=128k.bin bs=1024 count=128
dd if=/dev/urandom of=129k.bin bs=1024 count=129

When copying files from ksmbd share to windows or cifs.ko, The following
error message happen from windows client.

"The file '129k.bin' is too large for the destination filesystem."

We can see the error logs from ksmbd debug prints

[48394.611537] ksmbd: RDMA r/w request 0x0: token 0x669d, length 0x20000
[48394.612054] ksmbd: smb_direct: RDMA write, len 0x20000, needed credits 0x1
[48394.612572] ksmbd: filename 129k.bin, offset 131072, len 131072
[48394.614189] ksmbd: nbytes 1024, offset 132096 mincount 0
[48394.614585] ksmbd: Failed to process 8 [-22]

And we can reproduce it with cifs.ko,
e.g. dd if=129k.bin of=/dev/null bs=128KB count=2

This problem is that ksmbd rdma return error if remaining bytes is less
than Length of Buffer Descriptor V1 Structure.

smb_direct_rdma_xmit()
...
     if (desc_buf_len == 0 || total_length > buf_len ||
           total_length > t->max_rdma_rw_size)
               return -EINVAL;

This patch reduce descriptor size with remaining bytes and remove the
check for total_length and buf_len.

Cc: stable@vger.kernel.org
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/server/transport_rdma.c b/fs/smb/server/transport_rdma.c
index 7f222787c52c2c28a8e3d71786128f584464b3fd..3b269e1f523a17be690594c5c4e83ce4c965087f 100644 (file)
--- a/fs/smb/server/transport_rdma.c
+++ b/fs/smb/server/transport_rdma.c
@@ -1364,24 +1364,35 @@ static int smb_direct_rdma_xmit(struct smb_direct_transport *t,
        LIST_HEAD(msg_list);
        char *desc_buf;
        int credits_needed;
-       unsigned int desc_buf_len;
-       size_t total_length = 0;
+       unsigned int desc_buf_len, desc_num = 0;
 
        if (t->status != SMB_DIRECT_CS_CONNECTED)
                return -ENOTCONN;
 
+       if (buf_len > t->max_rdma_rw_size)
+               return -EINVAL;
+
        /* calculate needed credits */
        credits_needed = 0;
        desc_buf = buf;
        for (i = 0; i < desc_len / sizeof(*desc); i++) {
+               if (!buf_len)
+                       break;
+
                desc_buf_len = le32_to_cpu(desc[i].length);
+               if (!desc_buf_len)
+                       return -EINVAL;
+
+               if (desc_buf_len > buf_len) {
+                       desc_buf_len = buf_len;
+                       desc[i].length = cpu_to_le32(desc_buf_len);
+                       buf_len = 0;
+               }
 
                credits_needed += calc_rw_credits(t, desc_buf, desc_buf_len);
                desc_buf += desc_buf_len;
-               total_length += desc_buf_len;
-               if (desc_buf_len == 0 || total_length > buf_len ||
-                   total_length > t->max_rdma_rw_size)
-                       return -EINVAL;
+               buf_len -= desc_buf_len;
+               desc_num++;
        }
 
        ksmbd_debug(RDMA, "RDMA %s, len %#x, needed credits %#x\n",
@@ -1393,7 +1404,7 @@ static int smb_direct_rdma_xmit(struct smb_direct_transport *t,
 
        /* build rdma_rw_ctx for each descriptor */
        desc_buf = buf;
-       for (i = 0; i < desc_len / sizeof(*desc); i++) {
+       for (i = 0; i < desc_num; i++) {
                msg = kzalloc(offsetof(struct smb_direct_rdma_rw_msg, sg_list) +
                              sizeof(struct scatterlist) * SG_CHUNK_SIZE, GFP_KERNEL);
                if (!msg) {