]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: fsl: fsl_qmc_audio: Check devm_kasprintf() returned value
authorHerve Codina <herve.codina@bootlin.com>
Mon, 1 Jul 2024 11:30:28 +0000 (13:30 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 4 Jul 2024 11:24:52 +0000 (12:24 +0100)
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked.

Fix this lack and check the returned value.

Fixes: 075c7125b11c ("ASoC: fsl: Add support for QMC audio")
Cc: stable@vger.kernel.org
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Link: https://patch.msgid.link/20240701113038.55144-2-herve.codina@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_qmc_audio.c

index bfaaa451735b8fdba399db20038d88860d12fd54..dd90ef16fa973a6977e1e330854446aa0142b32f 100644 (file)
@@ -604,6 +604,8 @@ static int qmc_audio_dai_parse(struct qmc_audio *qmc_audio, struct device_node *
 
        qmc_dai->name = devm_kasprintf(qmc_audio->dev, GFP_KERNEL, "%s.%d",
                                       np->parent->name, qmc_dai->id);
+       if (!qmc_dai->name)
+               return -ENOMEM;
 
        qmc_dai->qmc_chan = devm_qmc_chan_get_byphandle(qmc_audio->dev, np,
                                                        "fsl,qmc-chan");