]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
list: test: fix tests for list_cut_position()
authorI Hsin Cheng <richard120310@gmail.com>
Tue, 10 Sep 2024 04:35:31 +0000 (12:35 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 17 Sep 2024 08:11:20 +0000 (01:11 -0700)
Fix test for list_cut_position*() for the missing check of integer "i"
after the second loop.  The variable should be checked for second time to
make sure both lists after the cut operation are formed as expected.

Link: https://lkml.kernel.org/r/20240910043531.71343-1-richard120310@gmail.com
Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
Cc: David Gow <davidgow@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/list-test.c

index 37cbc33e9fdb3808eab75c5a40398ee12f206132..8d1d47a9fe9ef63c4734ccda3f7ac0f2aaf95487 100644 (file)
@@ -404,10 +404,13 @@ static void list_test_list_cut_position(struct kunit *test)
 
        KUNIT_EXPECT_EQ(test, i, 2);
 
+       i = 0;
        list_for_each(cur, &list1) {
                KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]);
                i++;
        }
+
+       KUNIT_EXPECT_EQ(test, i, 1);
 }
 
 static void list_test_list_cut_before(struct kunit *test)
@@ -432,10 +435,13 @@ static void list_test_list_cut_before(struct kunit *test)
 
        KUNIT_EXPECT_EQ(test, i, 1);
 
+       i = 0;
        list_for_each(cur, &list1) {
                KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]);
                i++;
        }
+
+       KUNIT_EXPECT_EQ(test, i, 2);
 }
 
 static void list_test_list_splice(struct kunit *test)