]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
HID: i2c-hid: introduce re-power-on quirk
authorAleksandrs Vinarskis <alex.vinarskis@gmail.com>
Thu, 31 Oct 2024 07:31:41 +0000 (08:31 +0100)
committerJiri Kosina <jkosina@suse.com>
Wed, 11 Dec 2024 14:05:46 +0000 (15:05 +0100)
It appears some keyboards from vendor 'QTEC' will not work properly until
suspend & resume.

Empirically narrowed down to solution of re-sending power on command
_after_ initialization was completed before the end of initial probing.

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/i2c-hid/i2c-hid-core.c

index 4e87380d3edd6b845e57baffc41ad0bee2993b8c..c1c2ef9a9d68f7a0d3914c1d56c2cabb0e8f8dca 100644 (file)
@@ -51,6 +51,7 @@
 #define I2C_HID_QUIRK_NO_WAKEUP_AFTER_RESET    BIT(4)
 #define I2C_HID_QUIRK_NO_SLEEP_ON_SUSPEND      BIT(5)
 #define I2C_HID_QUIRK_DELAY_WAKEUP_AFTER_RESUME BIT(6)
+#define I2C_HID_QUIRK_RE_POWER_ON              BIT(7)
 
 /* Command opcodes */
 #define I2C_HID_OPCODE_RESET                   0x01
@@ -1073,7 +1074,11 @@ static int i2c_hid_core_register_hid(struct i2c_hid *ihid)
                return ret;
        }
 
-       return 0;
+       /* At least some QTEC devices need this after initialization */
+       if (ihid->quirks & I2C_HID_QUIRK_RE_POWER_ON)
+               ret = i2c_hid_set_power(ihid, I2C_HID_PWR_ON);
+
+       return ret;
 }
 
 static int i2c_hid_core_probe_panel_follower(struct i2c_hid *ihid)