]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
arm64: dts: exynos: correct PMIC interrupt trigger level on TM2
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:29:01 +0000 (22:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Mar 2021 17:22:37 +0000 (18:22 +0100)
[ Upstream commit e98e2367dfb4b6d7a80c8ce795c644124eff5f36 ]

The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20201210212903.216728-7-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi

index 297597442c44217e0f366995314f6c458ca3c7a1..7de6a187ba8f4794ba9a0a3cce4e6c29419fc6d0 100644 (file)
        s2mps13-pmic@66 {
                compatible = "samsung,s2mps13-pmic";
                interrupt-parent = <&gpa0>;
-               interrupts = <7 IRQ_TYPE_NONE>;
+               interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
                reg = <0x66>;
                samsung,s2mps11-wrstbi-ground;