]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
mac80211: Improve confusing comment around tx_info clearing
authorToke Høiland-Jørgensen <toke@toke.dk>
Mon, 4 Apr 2022 21:01:08 +0000 (23:01 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 11 Apr 2022 13:12:25 +0000 (15:12 +0200)
The comment above the ieee80211_tx_info_clear_status() helper was somewhat
confusing as to which fields it was or wasn't clearing. So replace it by
something that is hopefully more, well, clear.

Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Link: https://lore.kernel.org/r/20220404210108.2684907-1-toke@toke.dk
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
include/net/mac80211.h

index 382ebb862ea8fab897eccf8bb92470b45bb64aec..db992f71604d975f8049f64453d80285e924e047 100644 (file)
@@ -1201,9 +1201,9 @@ static inline struct ieee80211_rx_status *IEEE80211_SKB_RXCB(struct sk_buff *skb
  * in the TX status but the rate control information (it does clear
  * the count since you need to fill that in anyway).
  *
- * NOTE: You can only use this function if you do NOT use
- *      info->driver_data! Use info->rate_driver_data
- *      instead if you need only the less space that allows.
+ * NOTE: While the rates array is kept intact, this will wipe all of the
+ *      driver_data fields in info, so it's up to the driver to restore
+ *      any fields it needs after calling this helper.
  */
 static inline void
 ieee80211_tx_info_clear_status(struct ieee80211_tx_info *info)