hwmon: (pmbus) Add a PMBUS_NO_CAPABILITY platform data flag

Some PMBus chips don't respond with valid data when reading the
CAPABILITY register. Add a flag that device drivers can set so
that the PMBus core driver doesn't use CAPABILITY to determine it's
behavior.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20201222152640.27749-2-eajames@linux.ibm.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 192442b3b7a287424977d1f035a7378c06df57c2..906c9fec9cce1cdcf1d04db8d6ff76d348566a3d 100644 (file)
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -2204,9 +2204,11 @@ static int pmbus_init_common(struct i2c_client *client, struct pmbus_data *data,
        }
 
        /* Enable PEC if the controller supports it */
-       ret = i2c_smbus_read_byte_data(client, PMBUS_CAPABILITY);
-       if (ret >= 0 && (ret & PB_CAPABILITY_ERROR_CHECK))
-               client->flags |= I2C_CLIENT_PEC;
+       if (!(data->flags & PMBUS_NO_CAPABILITY)) {
+               ret = i2c_smbus_read_byte_data(client, PMBUS_CAPABILITY);
+               if (ret >= 0 && (ret & PB_CAPABILITY_ERROR_CHECK))
+                       client->flags |= I2C_CLIENT_PEC;
+       }
 
        /*
         * Check if the chip is write protected. If it is, we can not clear

diff --git a/include/linux/pmbus.h b/include/linux/pmbus.h
index 1ea5bae708a154c739d40c64c716128513adb84f..12cbbf30596960ac077cf1682d27d44593e80110 100644 (file)
--- a/include/linux/pmbus.h
+++ b/include/linux/pmbus.h
@@ -34,6 +34,15 @@
  */
 #define PMBUS_WRITE_PROTECTED  BIT(1)
 
+/*
+ * PMBUS_NO_CAPABILITY
+ *
+ * Some PMBus chips don't respond with valid data when reading the CAPABILITY
+ * register. For such chips, this flag should be set so that the PMBus core
+ * driver doesn't use CAPABILITY to determine it's behavior.
+ */
+#define PMBUS_NO_CAPABILITY                    BIT(2)
+
 struct pmbus_platform_data {
        u32 flags;              /* Device specific flags */