]> www.infradead.org Git - linux.git/commitdiff
ARM: dts: exynos: override pins by label in Peach Pi
authorKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Tue, 11 Jan 2022 20:17:01 +0000 (21:17 +0100)
committerKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Sun, 23 Jan 2022 16:54:52 +0000 (17:54 +0100)
Using node paths to extend or override a device tree node is error
prone.  If there was a typo error, a new node will be created instead of
extending the existing node.  This will lead to run-time errors that
could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Link: https://lore.kernel.org/r/20220111201722.327219-1-krzysztof.kozlowski@canonical.com
arch/arm/boot/dts/exynos5800-peach-pi.dts

index 77013ee586f87d75f1c7c45c37937e8743c1f47d..01f310f387d6177e858365100189b40c87fce719 100644 (file)
        };
 };
 
-&pinctrl_1 {
-       /* Adjust WiFi drive strengths lower for EMI */
-       sd1_clk: sd1-clk {
-               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
-       };
+/* pinctrl_1 */
+/* Adjust WiFi drive strengths lower for EMI */
+&sd1_bus1 {
+       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
 
-       sd1_cmd: sd1-cmd {
-               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
-       };
+&sd1_bus4 {
+       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
 
-       sd1_bus1: sd1-bus-width1 {
-               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
-       };
+&sd1_bus8 {
+       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
 
-       sd1_bus4: sd1-bus-width4 {
-               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
-       };
+&sd1_clk {
+       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
 
-       sd1_bus8: sd1-bus-width8 {
-               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
-       };
+&sd1_cmd {
+       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
 };
 
 &pinctrl_2 {
        };
 };
 
-&pinctrl_3 {
-       /* Drive SPI lines at x2 for better integrity */
-       spi2-bus {
-               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
-       };
+/* pinctrl_3*/
+/* Drive SPI lines at x2 for better integrity */
+&spi2_bus {
+       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
 
+&pinctrl_3 {
        /* Drive SPI chip select at x2 for better integrity */
        ec_spi_cs: ec-spi-cs {
                samsung,pins = "gpb1-2";