]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
eth: bnxt: apply hds_thrs settings correctly
authorJakub Kicinski <kuba@kernel.org>
Sun, 19 Jan 2025 02:05:14 +0000 (18:05 -0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Jan 2025 19:44:57 +0000 (11:44 -0800)
Use the pending config for hds_thrs. Core will only update the "current"
one after we return success. Without this change 2 reconfigs would be
required for the setting to reach the device.

Fixes: 6b43673a25c3 ("bnxt_en: add support for hds-thresh ethtool command")
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250119020518.1962249-5-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index 0998b20578b4e9e4129b341d4a0a2e7150ff0286..2eeed4c11b64bec1155323940705e1d2941af4c7 100644 (file)
@@ -6585,7 +6585,7 @@ static void bnxt_hwrm_update_rss_hash_cfg(struct bnxt *bp)
 
 static int bnxt_hwrm_vnic_set_hds(struct bnxt *bp, struct bnxt_vnic_info *vnic)
 {
-       u16 hds_thresh = (u16)bp->dev->cfg->hds_thresh;
+       u16 hds_thresh = (u16)bp->dev->cfg_pending->hds_thresh;
        struct hwrm_vnic_plcmodes_cfg_input *req;
        int rc;