bnx2x: Warn about grc timeouts in register dump

There are several scenarios where taking a register dump from a device
might log benign GRC timeout attentions to system logs.
Most common of those is when taking the dump from a 2-port device.

Sadly, there's no easy way to mask the problematic attentions during the
flow - Changing this behvaior would require a firmware update.
For now, simply warn users to ignore the warnings.

Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index 820b7e04bb5f3c296de6f2d57567416edfd7292a..85a7800bfc128e56b5a3886cba65b707ed5db57b 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -981,6 +981,11 @@ static void bnx2x_get_regs(struct net_device *dev,
        memcpy(p, &dump_hdr, sizeof(struct dump_header));
        p += dump_hdr.header_size + 1;
 
+       /* This isn't really an error, but since attention handling is going
+        * to print the GRC timeouts using this macro, we use the same.
+        */
+       BNX2X_ERR("Generating register dump. Might trigger harmless GRC timeouts\n");
+
        /* Actually read the registers */
        __bnx2x_get_regs(bp, p);