scsi: megaraid_sas: Change build_mpt_mfi_pass_thru to return void

Orabug: 26096381

Code refactoring to build_mpt_mfi_pass_thru to return void.

Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
(cherry picked from commit 7a7ae4f19280a4da2dfbdca3a414b0fd5fef2cb4)
Signed-off-by: Somasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Signed-off-by: Kirtikar Kashyap <kirtikar.kashyap@oracle.com>
Reviewed-by: Dhaval Giani <dhaval.giani@oracle.com>

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 1c28aa6e318abb6a1aee67ec1745c9ecdec04c0a..94549c6992144e14e236d6910cacd673905d4420 100644 (file)
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2955,7 +2955,7 @@ irqreturn_t megasas_isr_fusion(int irq, void *devp)
  * mfi_cmd:                    megasas_cmd pointer
  *
  */
-u8
+void
 build_mpt_mfi_pass_thru(struct megasas_instance *instance,
                        struct megasas_cmd *mfi_cmd)
 {
@@ -3005,8 +3005,6 @@ build_mpt_mfi_pass_thru(struct megasas_instance *instance,
                MPI2_IEEE_SGE_FLAGS_IOCPLBNTA_ADDR;
 
        mpi25_ieee_chain->Length = cpu_to_le32(instance->max_chain_frame_sz);
-
-       return 0;
 }
 
 /**
@@ -3021,11 +3019,7 @@ build_mpt_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd)
        union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc = NULL;
        u16 index;
 
-       if (build_mpt_mfi_pass_thru(instance, cmd)) {
-               dev_err(&instance->pdev->dev, "Couldn't build MFI pass thru cmd\n");
-               return NULL;
-       }
-
+       build_mpt_mfi_pass_thru(instance, cmd);
        index = cmd->context.smid;
 
        req_desc = megasas_get_request_descriptor(instance, index - 1);